Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new clojure lsp server info command #1232

Merged
merged 3 commits into from
Jul 11, 2021

Conversation

bpringe
Copy link
Member

@bpringe bpringe commented Jul 11, 2021

What has Changed?

  • Calls the clojure/serverInfo/raw clojure-lsp command instead of the now deprecated server-info command. Uses the raw version instead of the new version of the command that displays an information message because the server info is now too large to fit in the information message.
  • Prints the information to the Calva says window

Fixes #1211

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: You need to sign in/up at Circle CI to find the Artifacts tab.
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
    • If I am fixing the issue, I have used GitHub's fixes/closes syntax
    • If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • Created the issue I am fixing/addressing, if it was not present.

The Calva Team PR Checklist:

Before merging we (at least one of us) have:

  • Made sure the PR is directed at the dev branch (unless reasons).
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and tested it there if so.
  • Read the source changes.
  • Given feedback and guidance on source changes, if needed. (Please consider noting extra nice stuff as well.)
  • Tested the VSIX built from the PR (well, if this is a PR that changes the source code.)
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • If need be, had a chat within the team about particular changes.

Ping @PEZ, @bpringe

@bpringe
Copy link
Member Author

bpringe commented Jul 11, 2021

@pratik97 We need to use this raw server info command to display the info to the user now anyway, so I'll do that on this branch, and then you can use it in your code.

There seems to be an issue with clojure-lsp, which is discussed here: clojure-lsp/clojure-lsp#472

@bpringe bpringe changed the title Use new clojure lsp server info command 1211 Use new clojure lsp server info command Jul 11, 2021
@bpringe bpringe changed the base branch from published to dev July 11, 2021 20:04
Print output to Calva says channel
Close #1211
@bpringe
Copy link
Member Author

bpringe commented Jul 11, 2021

Update: There was no issue with clojure-lsp. I was calling the method as a command instead of as a custom LSP method like it is.

@bpringe bpringe marked this pull request as ready for review July 11, 2021 21:50
@bpringe bpringe merged commit 76d2e2b into dev Jul 11, 2021
@bpringe bpringe deleted the use_new_clojure-lsp_server-info_command_1211 branch July 11, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use new custom LSP method for server info command and print info in "Calva says" output channel
1 participant