Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new custom LSP method for server info command and print info in "Calva says" output channel #1211

Closed
bpringe opened this issue Jun 23, 2021 · 3 comments · Fixed by #1232
Labels

Comments

@bpringe
Copy link
Member

bpringe commented Jun 23, 2021

The clojure-lsp command used currently by Calva is being deprecated in favor of a new custom command that will return the server info and include additional information.

We should make the implementation for Calva's clojure-lsp server info command use the new custom command instead of the now deprecated one.

Reference: clojure-lsp/clojure-lsp#450 (comment)

@bpringe bpringe added the lsp label Jun 23, 2021
@bpringe
Copy link
Member Author

bpringe commented Jul 11, 2021

I noticed the server info is now too large to fit in a VSCode information message, so we should use the clojure/serverInfo/raw command and print it where it can be fully read.

image

@bpringe
Copy link
Member Author

bpringe commented Jul 11, 2021

@PEZ, regarding the above, where should we show this information to the user now? Some ideas:

  1. Just copy it to their clipboard and display a message like "Clojure-lsp server info copied to clipboard"
  2. Print it to the output window, even though the REPL may not be connected and the window may not be open (we would open it in this case, of course)
  3. Print it to the Calva says output channel and show the channel

@ericdallo
Copy link
Contributor

I like the third option :)

@bpringe bpringe changed the title Use new clojure-lsp server info command Use new clojure-lsp server info command and print info in Calva says output channel Jul 11, 2021
@bpringe bpringe changed the title Use new clojure-lsp server info command and print info in Calva says output channel Clojure-lsp Server Info command: use new custom lsp method and print info in Calva says output channel Jul 11, 2021
@bpringe bpringe changed the title Clojure-lsp Server Info command: use new custom lsp method and print info in Calva says output channel Clojure-lsp Server Info command: use new custom LSP method and print info in Calva says output channel Jul 11, 2021
@bpringe bpringe changed the title Clojure-lsp Server Info command: use new custom LSP method and print info in Calva says output channel Use new custom LSP method for server info command and print info in "Calva says" output channel Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants