Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix completion info call to use the correct ns #1084

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented Mar 29, 2021

What has Changed?

For the documentation part of the completion handler we were sending along whatever was in the "ns" entry in the item's insertText property. (In the case of symbols with aliased namespaces, this seems to have been the aliased namespace itself, how that could be I do not understand, but it is cool in a way.)

Now we send the document's namespace as any civilized nrepl client should be doing.

Fixes #1083

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: There is a CircleCI bug that makes the Artifacts hard to find. Please see this issue for workarounds.
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.

Ping @bpringe

@PEZ PEZ merged commit 707e5ed into dev Mar 30, 2021
@PEZ PEZ deleted the 1083-fix-complete-info branch April 6, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant