You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
.. and cursor positioned just after the / in str/, calva sends incorrect namespaces in :info messages sent to cider-nrepl server when doing code completion via ctrl+space. Instead of passing foo as :ns in the message, it's actually passing clojure.string. This is what server receives when navigating between the offered code-completed functions:
pez:calva: 1:14 PM
Hmmm, seems we’re on to something. Calva sends info (correctly) on hover. But also this one with a funny ns when I hit ctrl+space.
pez:calva: 1:22 PM
Yes, wrong ns, even though that has so far not mattered b/c I think that the “regular” nrepl server figures that out, like it also doesn’t actually need the ns. It was added recently because babashka wanted it.
I’ll fix it.
pez:calva: 1:34 PM
The ns thing is just a bug that has gone unnoticed until now.
At least I think so. It looks very deliberate when i look at the code. 😃
FYI The plain emacs + cider + company-mode sends message in following format to nrepl server when fetching information about function params on code-completion. (they're actually using "eldoc" but using "info" or "lookup" should be fine (they just have a bit different keys in the response):
msg {:op:eldoc, :ns foo, :sym str/includes?, :session4d8840fd-31e9-46a4-9a89-637251afcef9, :id133}
reply: {ns clojure.string, name includes?, eldoc [[s substr]], type function, status #{done}, docstring True if s includes substr.}
msg {:op:eldoc, :ns foo, :sym str/index-of, :session4d8840fd-31e9-46a4-9a89-637251afcef9, :id134}
reply: {ns clojure.string, name index-of, eldoc [[s value] [s value from-index]], type function, status #{done}, docstring Return index of value (string or char) in s, optionally searching
forward from from-index. Return nilif value not found.}
The text was updated successfully, but these errors were encountered:
brdloush
changed the title
calva sends incorrect namespaces for aliased
calva sends incorrect namespaces for "info" nrepl resolution of aliased symbols'
Mar 29, 2021
brdloush
changed the title
calva sends incorrect namespaces for "info" nrepl resolution of aliased symbols'
calva sends incorrect namespaces for "info" nrepl resolution of aliased symbols
Mar 29, 2021
brdloush
changed the title
calva sends incorrect namespaces for "info" nrepl resolution of aliased symbols
incorrect namespace being sent for "info" nrepl resolution of aliased symbols
Mar 29, 2021
PEZ
changed the title
incorrect namespace being sent for "info" nrepl resolution of aliased symbols
incorrect namespace being sent for "info" nrepl resolution of aliased symbols in completion handler
Mar 29, 2021
(Creating issue for this as @PEZ asked on slack channel #babashka-sci-dev)
With following code..
.. and cursor positioned just after the
/
instr/
, calva sends incorrect namespaces in:info
messages sent to cider-nrepl server when doing code completion viactrl+space
. Instead of passingfoo
as:ns
in the message, it's actually passingclojure.string
. This is what server receives when navigating between the offered code-completed functions:Instead of
"clojure.string"
,"foo"
should be sent in this case.According to slack conversation in https://clojurians.slack.com/archives/G01J18EUH6H/p1617016471044200,
FYI The plain
emacs
+cider
+company-mode
sends message in following format to nrepl server when fetching information about function params on code-completion. (they're actually using"eldoc"
but using"info"
or"lookup"
should be fine (they just have a bit different keys in the response):The text was updated successfully, but these errors were encountered: