Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete button to LimitsMonitor items #716

Merged
1 commit merged into from
Feb 9, 2018
Merged

Conversation

ghost
Copy link

@ghost ghost commented Feb 2, 2018

closes #715

@ghost ghost self-requested a review February 2, 2018 22:25
@codecov-io
Copy link

codecov-io commented Feb 2, 2018

Codecov Report

Merging #716 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #716      +/-   ##
==========================================
+ Coverage   86.21%   86.23%   +0.01%     
==========================================
  Files         159      159              
  Lines       14867    14867              
==========================================
+ Hits        12818    12820       +2     
+ Misses       2049     2047       -2
Impacted Files Coverage Δ
lib/cosmos/packet_logs/packet_log_writer.rb 93.41% <0%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00365fe...4a3ea7c. Read the comment docs.

@ghost
Copy link

ghost commented Feb 8, 2018

👍

@ghost ghost merged commit 2a4ce20 into master Feb 9, 2018
@ghost ghost deleted the remove_limits_monitor_items branch February 9, 2018 19:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow individual Limits Monitor items to be removed (not ignored)
2 participants