Fix loading with write conversion #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-requested a review
ghost
commented
Oct 18, 2019
| # If they passed in existing values override them here | ||
| if existing | ||
| existing.each do |param_name, param_value| | ||
| old_params[param_name] = param_value.to_s |
There was a problem hiding this comment.
This is the essence of the fix. Use the parameter text directly instead of writing the underlying packet.
Codecov Report
@@ Coverage Diff @@
## master #1066 +/- ##
==========================================
+ Coverage 84.15% 84.16% +<.01%
==========================================
Files 165 165
Lines 15746 15806 +60
==========================================
+ Hits 13251 13303 +52
- Misses 2495 2503 +8
Continue to review full report at Codecov.
|
ghost
approved these changes
Nov 18, 2019
|
I added a few more AHK test steps. Specifically the Export function which I would have broke with this fix. Also forgot to add the new file cmd_params! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1064