Vigil Storm Shields again and Sabre Pintle weapons #3154
Conversation
#3153 Issue happened again with the coding of the Termy weapon SGSE for vigil shields in Jan/Feb. This fix was put in to fix that Termy Praetors were mistakenly being given an option to swap their combi weapon for a vigil shield. However in fixing it it then locked out any command squad they took from taking them (though was ok for Artificer Praetors). It was a problem with "Ancestor Of" being used for the Praetors without making an exception for the command squad that comes below them. I have made what seems to be a fix by splitting the "OR" for hidden from just Cata or Tart praetor as Ancestor to then have 2 "AND" sections of the same function, but then added 2 additional lines to also check to make sure they are "ancestor is not instance of cata / termy command squad" as well. I've only tested on BS, and I know NR handles things differently.
Fix for Sabre Tanks Pintle Weapons. There was an issue on BS that when you selected any of the combi weapon options for sabres, it was enforcing the selection on the whole group. This was down to the entries linked were for some reason linked to the "Collective" version of the weapons, and not the individual ones.
Mayegelt
changed the title
|
Fix for Sabre Tanks Pintle Weapons. |
|
Strange things going on. It is saying over 50,000 changes, gunna try to work out why. This happened before and on resubmitting the changes it worked. |
|
@nstephenh @The4D6 Ok. I have changed the bits I needed to. However as you might be able to see from the other pull request. It seems when I save (even if the only change I made was change the version number) it then throws a fix and changes 50,000 entry lines. |
#3153
Issue happened again with the coding of the Termy weapon SGSE for vigil shields in Jan/Feb. This fix was put in to fix that Termy Praetors were mistakenly being given an option to swap their combi weapon for a vigil shield. However in fixing it it then locked out any command squad they took from taking them (though was ok for Artificer Praetors). It was a problem with "Ancestor Of" being used for the Praetors without making an exception for the command squad that comes below them.
I have made what seems to be a fix by splitting the "OR" for hidden from just Cata or Tart praetor as Ancestor to then have 2 "AND" sections of the same function, but then added 2 additional lines to also check to make sure they are "ancestor is not instance of cata / termy command squad" as well.
I've only tested on BS, and I know NR handles things differently.