-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imperial Fist Tartaros Command squad unable to select Vigil Storm Shield #3153
Comments
Hi ya. It will be fixed again. Unfortunately this has happened a couple of times in exactly the same scenario of X + Y not allowing Z. |
Doing a small dig it looks like it is an "ancestor of" issue. Unfortunately I assume this was not checked in testing before it was released. Or may have been tested on a program other than BS (as I know some issues have occurred this way as well). |
#3153 Issue happened again with the coding of the Termy weapon SGSE for vigil shields in Jan/Feb. This fix was put in to fix that Termy Praetors were mistakenly being given an option to swap their combi weapon for a vigil shield. However in fixing it it then locked out any command squad they took from taking them (though was ok for Artificer Praetors). It was a problem with "Ancestor Of" being used for the Praetors without making an exception for the command squad that comes below them. I have made what seems to be a fix by splitting the "OR" for hidden from just Cata or Tart praetor as Ancestor to then have 2 "AND" sections of the same function, but then added 2 additional lines to also check to make sure they are "ancestor is not instance of cata / termy command squad" as well. I've only tested on BS, and I know NR handles things differently.
As suspected, it was an "Ancestor of" issue. I have put up a pull request that should resolve this (if it goes through). |
Thanks guys. |
Describe the bug
Imperial Fist Tartaros Comand Squad is missing the option to replace it's ranged weapon with a Vigil Storm Shield.
Steps to reproduce the behavior:
Expected behavior
In the "Terminator Ranged Weapon" section there should be the option to replace the combi-bolter with a Vigil Storm Shield.
Device and data (please complete the following information):
Additional context
This all happened due to bug "Imperial Fists HQs Cannot Swap Guns for Shields #3069"
Where user The4D6 stated:
"I may be wrong here, so feel free to correct me if I am.
Both kinds of Imperial Fists terminator praetors have the option to exchange a combi-bolter for a vigil storm shield for 10pts.
They should not have this option."
He is wrong. Very wrong. Liber Astartes pg 228 clearly states that Imperial Fist Tartaros and Cataphractii units and command squads can replace their combi-bolter with a Vigil Storm Shield. +15 points for Tartaros squads and +10 for Cataphractii.
Not to be a jerk, but it's really annoying that this got broken because some random files a bug stating what he THINKS is a problem and does zero actual investigation. This is made worse by the fact you guys just took his word for it. Hot tip, if a bug report starts with "I may be wrong" just assume they are. Particularly if they aren't going to back their nonsense up with references.
The text was updated successfully, but these errors were encountered: