This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Fix install:packages:link
#769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanmccombe
requested review from
dr3,
j-pendlebury,
pjlee11 and
sareh
as code owners
dr3
previously requested changes
Jul 3, 2019
3 tasks
pjlee11
suggested changes
Jul 5, 2019
pjlee11
approved these changes
Jul 5, 2019
|
No QA needed here, as it only impacts Psammead development |
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #756
Overall change: Update the usage of the
inputProviderhelper to match the APICode changes:
inputProvidercallback is called with an object - most of the consumers of this function (but not the unit tests) were assuming the callback was invoked with multiple argumentsIt's surprising this ever worked at all