Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Many storybook stories do not work after install:packages:link #756

Closed
ryanmccombe opened this issue Jul 2, 2019 · 0 comments · Fixed by #769
Closed

Many storybook stories do not work after install:packages:link #756

ryanmccombe opened this issue Jul 2, 2019 · 0 comments · Fixed by #769
Assignees
Labels
bug Something isn't working simorgh-core-stream ws-articles Tasks for the WS Articles Team ws-home Tasks for the WS Home Team

Comments

@ryanmccombe
Copy link
Contributor

Describe the bug
When a developer runs the install:packages:link script, around half of the stories in storybook do not load

To Reproduce

  1. Pull project
  2. npm run install:packages:link
  3. npm run storybook and navigate through the stories

Expected behavior
Stories load and show the components

Screenshots
Screen Shot 2019-07-02 at 16 34 30

Additional context
It was noted that the stories that error in this way all appear to be using inputProvider function - this is likely the cause of the issue

There is also a version mismatch in most of the packages, although Lerna's --hoist flag reportedly handles this scenario correctly, so inputProvider is likely the problem

@ryanmccombe ryanmccombe added the bug Something isn't working label Jul 2, 2019
@j-pendlebury j-pendlebury added ws-articles Tasks for the WS Articles Team ws-home Tasks for the WS Home Team labels Jul 2, 2019
@ryanmccombe ryanmccombe self-assigned this Jul 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working simorgh-core-stream ws-articles Tasks for the WS Articles Team ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants