Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Replace storybook addon with dirDecorator #515

Merged
10 commits merged into from
May 13, 2019
Merged

Replace storybook addon with dirDecorator #515

10 commits merged into from
May 13, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 13, 2019

Resolves #508

Overall change: Update stories to use dirDecorator

Code changes:

  • Remove storybook-addon-rtl and update storybook config
  • Update MediaIndicator, Brand, Caption and Timestamp stories to use dirDecorator

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@ghost ghost added the ws-home Tasks for the WS Home Team label May 13, 2019
@ghost ghost self-assigned this May 13, 2019
@ghost ghost marked this pull request as ready for review May 13, 2019 08:12
Copy link
Contributor

@DenisHdz DenisHdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@david-boydell
Copy link

LGTM

@ghost ghost merged commit 33c1123 into latest May 13, 2019
@ghost ghost deleted the replace-storybook-addon branch May 13, 2019 13:35
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace storybook-addon-rtl with dirDecorator
4 participants