Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Replace storybook-addon-rtl with dirDecorator #508

Closed
ghost opened this issue May 9, 2019 · 0 comments · Fixed by #515
Closed

Replace storybook-addon-rtl with dirDecorator #508

ghost opened this issue May 9, 2019 · 0 comments · Fixed by #515
Labels
ws-home Tasks for the WS Home Team
Milestone
Localisation & Fo...

Comments

@ghost
Copy link

ghost commented May 9, 2019 •
edited by ghost
Loading

Is your feature request related to a problem? Please describe.
Now that we have both the inputProvider and dirDecorator they cover the functionality provided by storybook-addon-rtl. We should therefore remove the dependency on storybook-addon-rtl

Describe the solution you'd like
Remove the dependency on storybook-addon-rtl and update stories that were dependent on its functionality like Brand, Caption,Timestamp and MediaIndicator.

Describe alternatives you've considered

Testing notes
[Tester to complete]

Dev insight: Storybook functionality regression

Additional context
Add any other context or screenshots about the feature request here.
@ghost ghost added the ws-home Tasks for the WS Home Team label May 9, 2019
@ghost ghost added the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label May 9, 2019
@dr3 dr3 added this to the Localisation & Fonts (WS FP) milestone May 9, 2019
@dr3 dr3 removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label May 9, 2019
@ghost ghost self-assigned this May 9, 2019
This was referenced May 10, 2019
Merged
Merged
@ghost ghost closed this as completed in #515 May 13, 2019
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
Localisation & Fonts (WS FP)
Development

Successfully merging a pull request may close this issue.

Replace storybook addon with dirDecorator BBC-archive/psammead
1 participant
@dr3