Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Update dirDecorator to pass script and dir to storybook function #512

Merged
7 commits merged into from
May 10, 2019

Conversation

ghost
Copy link

@ghost ghost commented May 10, 2019

Contributes to #508

Overall change: Update dirDecorator to pass script and dir to storybook function.

Code changes:

  • Passed dir and script to storybook function to allow them to be used in components i.e.
addDecorator(dirDecorator)
.add('Timestamp', ({ script }) => (
  <Timestamp script={script} /* other props *//>
)

  • I have assigned myself to this PR and the corresponding issues
  • Tests added for new features
  • Test engineer approval

@ghost ghost added the ws-home Tasks for the WS Home Team label May 10, 2019
@ghost ghost self-assigned this May 10, 2019
Copy link
Contributor

@j-pendlebury j-pendlebury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jamesbrumpton
Copy link
Contributor

LGTM. Happy for this to be merged.

@ghost ghost merged commit 4fe8936 into latest May 10, 2019
@ghost ghost deleted the remove-rtl-addon branch May 10, 2019 13:53
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants