This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Add Themes to Storybook Helpers #3586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
pharingee
approved these changes
Jul 9, 2020
pharingee
reviewed
Jul 9, 2020
| }); | ||
|
|
||
| export default { | ||
| light: createTheme({ base: 'light' }), |
There was a problem hiding this comment.
Should we call this mode instead of base? Just thinking
There was a problem hiding this comment.
base is from the storybook-theming api - it's not something we can rename unfortunately
https://storybook.js.org/docs/configurations/theming/#create-a-theme-quickstart
rebeccamcginn
approved these changes
Jul 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirement for bbc/simorgh#7178
Overall change:
Move storybook themes into psammead-helpers
Preparation work for allowing individual stories to change the storybook theme, when using dark mode
Code changes: