Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cinema Mode - On Demand TV #7178

Closed
ryanmccombe opened this issue Jul 8, 2020 · 1 comment · Fixed by BBC-archive/psammead#3590 or #7206
Closed

Cinema Mode - On Demand TV #7178

ryanmccombe opened this issue Jul 8, 2020 · 1 comment · Fixed by BBC-archive/psammead#3590 or #7206
Assignees
@ryanmccombe
Labels
ux To be reviewed by UX before merging ws-media World Service Media

Comments

@ryanmccombe
Copy link
Contributor

WSMEDIA-236
@ryanmccombe ryanmccombe self-assigned this Jul 8, 2020
@ryanmccombe ryanmccombe added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. ws-media World Service Media labels Jul 8, 2020
This was referenced Jul 8, 2020
Merged
Merged
Merged
Merged
@ryanmccombe ryanmccombe reopened this Jul 13, 2020
@karinathomasbbc karinathomasbbc added ux To be reviewed by UX before merging OD-TV and removed Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. labels Jul 14, 2020
@LilyL0u
Copy link
Contributor

LilyL0u commented Jul 16, 2020

Image 13-07-2020 at 13 14

High contrast mode on the 'High Contrast' accessibility tool actually decreases the contrast as it darkens the player image as if the page had a white background and needed darker to contrast against it.

However, I think this is a limitation of the tool, as looking at a similar cinema mode on another website, The Guardian Videos, it does the same thing with decreasing the contrast.

@ryanmccombe ryanmccombe mentioned this issue Aug 5, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanmccombe ryanmccombe

Labels
ux To be reviewed by UX before merging ws-media World Service Media
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add midnight color BBC-archive/psammead
[DO NOT MERGE] TV Cinema Mode - Live bbc/simorgh
4 participants
@ryanmccombe @amywalkerdev @LilyL0u @karinathomasbbc