This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Radio Schedules - Fix VoiceOver bug with the NEXT card headline #3348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlgaLyubin
reviewed
Apr 8, 2020
| @@ -226,34 +226,39 @@ exports[`ProgramCard should render correctly for live 1`] = ` | |||
| href="/news/articles/cn7k01xp8kxo" | |||
| > | |||
| <span | |||
| class="" | |||
There was a problem hiding this comment.
Looks great, just wondering if it's fine to have empty classes in snapshots?
There was a problem hiding this comment.
I believe that since we don't add styles when declaring that styled component:
const HeadingContentWrapper = styled.span.attrs({ role: 'text' })``;
it leaves the class empty as it doesn't have to target it to apply styles.
It also happens for the DurationTextWrapper.
There was a problem hiding this comment.
I also wondered why that was there...
|
Looks good, thanks @DenisHdz |
OlgaLyubin
approved these changes
Apr 8, 2020
itimirichard
approved these changes
Apr 8, 2020
This was referenced Apr 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3347
Overall change:
In this PR we removed the span that was wrapping the Promo Card Headline in order to simplify the markup. Unfortunately, this is necessary to avoid VoiceOver splitting the content within it.
Code changes:
HeadingContentWrapperback with the role='text'