-
Notifications
You must be signed in to change notification settings - Fork 54
Radio Schedules - Update Program Card Heading markup and CSS #3326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍 . DOM structure also looks more simple as there are fewer span elements.
This can be merged.As per testing by @DenisHdz heading level h3 is read out only once when navigating via the heading/link. |
On that note, I'd like to add that thanks to these changes, it is also announced just once when navigating via elements with the arrow keys. |
… into simplify-radio-schedule-dom
Resolves #3305
Overall change:
Update Program Card Heading markup and CSS to fix a11y bugs explained in the issue.
Code changes:
HeadingContentWrapper
as @greenc05 pointed in Use Live Label in Radio Schedules, and pass in translations #3297 (comment)display:inline
withdisplay:inline-block
in theTitleWrapper
span to fix the a11y bug. These changes require:width: 100%
so it stays under the headlinetext-decoration: underline;
when hovering or focus over the Link, otherwise it just underlines the first part of the h3