Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Radio Schedules - Update Program Card Heading markup and CSS #3326

Merged
merged 8 commits into from
Apr 6, 2020

Conversation

DenisHdz
Copy link
Contributor

@DenisHdz DenisHdz commented Apr 2, 2020

Resolves #3305

Overall change:
Update Program Card Heading markup and CSS to fix a11y bugs explained in the issue.

Code changes:

  • Remove HeadingContentWrapper as @greenc05 pointed in Use Live Label in Radio Schedules, and pass in translations #3297 (comment)
  • Replace display:inline with display:inline-block in the TitleWrapper span to fix the a11y bug. These changes require:
    • Apply a width: 100% so it stays under the headline
    • Apply the text-decoration: underline; when hovering or focus over the Link, otherwise it just underlines the first part of the h3

  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@DenisHdz DenisHdz added ws-home Tasks for the WS Home Team radio-schedules labels Apr 2, 2020
@DenisHdz DenisHdz self-assigned this Apr 2, 2020
Copy link
Contributor

@OlgaLyubin OlgaLyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@Bopchy Bopchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍 . DOM structure also looks more simple as there are fewer span elements.

@PriyaKR PriyaKR self-assigned this Apr 3, 2020
@PriyaKR
Copy link
Contributor

PriyaKR commented Apr 6, 2020

This can be merged.As per testing by @DenisHdz heading level h3 is read out only once when navigating via the heading/link.
Also a regression looks good to me.

@DenisHdz
Copy link
Contributor Author

DenisHdz commented Apr 6, 2020

This can be merged.As per testing by @DenisHdz heading level h3 is read out only once when navigating via the heading/link.
Also a regression looks good to me.

On that note, I'd like to add that thanks to these changes, it is also announced just once when navigating via elements with the arrow keys.

@DenisHdz DenisHdz merged commit 3b424b7 into latest Apr 6, 2020
@DenisHdz DenisHdz deleted the simplify-radio-schedule-dom branch April 6, 2020 11:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
radio-schedules ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify the DOM structure within Headings in the radio schedule component
5 participants