Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Add list bullet SVG to psammead-assets #2658

Closed
wants to merge 10 commits into from
Closed

Add list bullet SVG to psammead-assets #2658

wants to merge 10 commits into from

Conversation

pharingee
Copy link
Contributor

@pharingee pharingee commented Nov 20, 2019 •
edited
Loading

Needed for #2583

Overall change:
Add plain icons to psammead-assets and include list bullet.

Code changes:

  • Create a PlainIcons set of icons that cannot be classed.
  • Add bullet to icon
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@pharingee pharingee added ws-media The World Service media stream ws-media-asset-page-v2 labels Nov 20, 2019
@pharingee pharingee self-assigned this Nov 20, 2019
@pharingee pharingee requested a review from jroebu14 November 20, 2019 11:30
@pharingee
Copy link
Contributor Author

Closing to move SVG to psammead-bulleted-list component

@pharingee pharingee closed this Nov 20, 2019
@sareh sareh deleted the add-bullet-svg branch December 30, 2019 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamesbhobbs jamesbhobbs Awaiting requested review from jamesbhobbs

@craigkj craigkj Awaiting requested review from craigkj

@j-pendlebury j-pendlebury Awaiting requested review from j-pendlebury

@sareh sareh Awaiting requested review from sareh

@jroebu14 jroebu14 Awaiting requested review from jroebu14

Assignees

@pharingee pharingee

Labels
ws-media The World Service media stream ws-media-asset-page-v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pharingee @jroebu14