Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Create psammead-bulleted-list component #2583

Merged
merged 42 commits into from
Nov 21, 2019
Merged

Create psammead-bulleted-list component #2583

merged 42 commits into from
Nov 21, 2019

Conversation

pharingee
Copy link
Contributor

@pharingee pharingee commented Nov 7, 2019 •
edited
Loading

Resolves #2579

Overall change:
Create @bbc/psammead-bulleted-list component

Code changes:

  • Create component package
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@pharingee pharingee added a11y Accessibility-related task a11y-swarm An a11y swarm (clarify dev or full team in the desc) needs to be carried out before moving to test ws-media The World Service media stream ws-media-asset-page-v2 labels Nov 7, 2019
@pharingee pharingee self-assigned this Nov 7, 2019
@pharingee pharingee mentioned this pull request Nov 20, 2019
Closed
3 tasks
OlgaLyubin
OlgaLyubin reviewed Nov 21, 2019
View reviewed changes
Copy link
Contributor

@OlgaLyubin OlgaLyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Just needs fixing Jenkins because it is complaining about this:

Screenshot 2019-11-21 at 09 10 04

jroebu14
jroebu14 approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@jroebu14 jroebu14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@amywalkerdev
Copy link
Contributor

Looks like linting tests (maybe?) are failing on CI

packages/components/psammead-bulleted-list/src/index.jsx
19:20 ✖ Unknown word CssSyntaxError

@pharingee
Copy link
Contributor Author

Yes, I fixed them in my last push. Should be good now

@pharingee pharingee merged commit 74dda31 into latest Nov 21, 2019
@amywalkerdev amywalkerdev deleted the psammead-bulleted-list branch November 21, 2019 10:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@OlgaLyubin OlgaLyubin OlgaLyubin left review comments

@jroebu14 jroebu14 jroebu14 approved these changes

@ryanmccombe ryanmccombe ryanmccombe approved these changes

@jamesbhobbs jamesbhobbs Awaiting requested review from jamesbhobbs

@dr3 dr3 Awaiting requested review from dr3

@j-pendlebury j-pendlebury Awaiting requested review from j-pendlebury

@sareh sareh Awaiting requested review from sareh

@craigkj craigkj Awaiting requested review from craigkj

@hotinglok hotinglok Awaiting requested review from hotinglok

Assignees

@pharingee pharingee

Labels
a11y Accessibility-related task a11y-swarm An a11y swarm (clarify dev or full team in the desc) needs to be carried out before moving to test ws-media The World Service media stream ws-media-asset-page-v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create psammead-bulleted-list component
6 participants
@pharingee @hotinglok @amywalkerdev @jroebu14 @ryanmccombe @OlgaLyubin