This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
Increase package utilities test coverage #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
December 17, 2018 14:02
- Using the testing helper function to test the test helpers; That's pretty damn meta - Add testing for the error and console.log in `testUtilityPackages`
…tilities-test-coverage
…s/psammead into increase-utilities-test-coverage
…tching keys - change the log to an Error - if actual export has differing keys than the expected then Error - if expected has differing keys than the actual export then Error
…tilities-test-coverage
added 6 commits
January 3, 2019 17:44
…s/psammead into increase-utilities-test-coverage
pjlee11
added
alpha-2
blocked
3 tasks
pjlee11
removed
the
blocked
|
Only 42 commits? You could do with a boost ;) |
bcmn
reviewed
Jan 8, 2019
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| | Version | Description | | |||
| |---------|-------------| | |||
| | 0.1.4 | [PR#224](https://github.com/BBC-News/psammead/pull/224) Add tests for the exported values, coverage 100% :tada: | | |||
There was a problem hiding this comment.
What's happened to changelog info for 0.1.2 & 0.1.3? 😬 The package.json seems to imply these versions existed.
I know this isn't your PR, just intriguing.
There was a problem hiding this comment.
Using git blame it seems this happened - 0934585
🤐
There was a problem hiding this comment.
For the wider context it was as part of this PR https://github.com/bbc/psammead/pull/212/files
bcmn
approved these changes
Jan 8, 2019
dr3
approved these changes
Jan 8, 2019
|
LGTM 👍 |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #224
Follows up on #224 is dependant on #258.
Add tests for the package utilities using the newly created method in #258
To test this run
npm install && npm run build && npm run testensuring there are no errors. The test coverage for the packagesgel-foundations,psammead-assetsandpsammead-stylesshould all change from0%to100%.