This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 54
Add and use method to test a package's exported values #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry pick changes to `psammead-test-helpers` from the POC PR - #224
3 tasks
ChrisBAshton
reviewed
Jan 4, 2019
bcmn
previously approved these changes
Jan 4, 2019
bcmn
previously approved these changes
Jan 4, 2019
ChrisBAshton
previously approved these changes
Jan 4, 2019
3 tasks
0e9ca64
to
9a19c45
Compare
…age-helper-method
9a19c45
to
907744c
Compare
snyk stalling on jobs so re-committing ... |
ChrisBAshton
approved these changes
Jan 7, 2019
Confirmed that synk is hanging as the webhooks are looking at the wrong github repo |
bcmn
approved these changes
Jan 7, 2019
LGTM 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of 2 for #156
Follows up on #224
Adds a test helper method that takes an actual import and validates it has all the exported values it is expected to have. This can then be used to simplifying testing the other utility packages exports as well as
psammead-test-helpers
Has error handling logic for both new files (EG: font.js) and for exported files within those files when:
Testing this involves ensuring no regression in the
psammead-test-helpers
package, which can be verified via runningnpm run build & npm run test
. Also thepsammead-test-helpers
package test coverage should increase from0%
to51.28%