Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Fix Storybook console errors #2460

Merged
merged 2 commits into from
Oct 23, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/psammead-image/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<!-- prettier-ignore -->
| Version | Description |
|---------|-------------|
| 1.2.3 | [PR#2460](https://github.com/bbc/psammead/pull/2460) Fix Storybook console errors |
| 1.2.2 | [PR#1942](https://github.com/bbc/psammead/pull/1942) Talos - Bump React to 16.9.0 |
| 1.2.1 | [PR#1803](https://github.com/bbc/psammead/pull/1803/) Patches broken links on badges in documentation |
| 1.2.0 | [PR#1794](https://github.com/bbc/psammead/pull/1794) Add david dependency badges |
Expand Down
2 changes: 1 addition & 1 deletion packages/components/psammead-image/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/components/psammead-image/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bbc/psammead-image",
"version": "1.2.2",
"version": "1.2.3",
"main": "dist/index.js",
"module": "esm/index.js",
"sideEffects": false,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import AmpImg from './index.amp';
import stories from './testHelpers/stories';
import { stories } from './testHelpers/stories';
import { ampDecorator } from '../../../../.storybook/config';

const additionalProps = {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/psammead-image/src/index.stories.jsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';
import { withKnobs } from '@storybook/addon-knobs';
import { Img } from '.';
import stories, { getProps } from './testHelpers/stories';
import { stories, getProps } from './testHelpers/stories';
import { landscape } from './testHelpers/fixtureData';
import notes from '../README.md';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export function getProps(image, includeHeight, type) {
return props;
}

const stories = (
export const stories = (
Component,
title,
includeHeight = false,
Expand Down Expand Up @@ -79,5 +79,3 @@ const stories = (
),
{ notes },
);

export default stories;