Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Fix Storybook console errors #2460

Merged
merged 2 commits into from
Oct 23, 2019
Merged

Fix Storybook console errors #2460

merged 2 commits into from
Oct 23, 2019

Conversation

FK78
Copy link
Contributor

@FK78 FK78 commented Oct 22, 2019

Resolves #2459

Overall change: Converted default exports to named exports.

Code changes:

  • Change default exports to named exports.
  • Change edit imports.
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@FK78 FK78 added this to the Psammead 3.0 milestone Oct 22, 2019
@FK78 FK78 self-assigned this Oct 22, 2019
@jroebu14
Copy link
Contributor

jroebu14 commented Oct 22, 2019 •
edited
Loading

Branch must update CHANGELOG.md in psammead-image

Branch must update package-lock.json in psammead-image

Branch must update package.json in psammead-image

@chris-hinds chris-hinds merged commit 1ba743f into latest Oct 23, 2019
@chris-hinds chris-hinds deleted the storybook-console-errors branch October 23, 2019 09:29
This was referenced Oct 23, 2019
Closed
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jroebu14 jroebu14 jroebu14 approved these changes

@ryanmccombe ryanmccombe ryanmccombe approved these changes

@thekp thekp thekp approved these changes

@jamesbhobbs jamesbhobbs Awaiting requested review from jamesbhobbs

@dr3 dr3 Awaiting requested review from dr3

@j-pendlebury j-pendlebury Awaiting requested review from j-pendlebury

@sareh sareh Awaiting requested review from sareh

Assignees

@FK78 FK78

Labels
simorgh-core-stream
Projects
None yet
Milestone
Psammead 3.0
Development

Successfully merging this pull request may close these issues.

Storybook console errors
5 participants
@FK78 @jroebu14 @ryanmccombe @thekp @chris-hinds