Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Fix headline font-size in standard story-promo #1930

Merged
16 commits merged into from
Aug 30, 2019
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/psammead-story-promo/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<!-- prettier-ignore -->
| Version | Description |
| ------- | ----------- |
| 2.7.1 | [PR#1930](https://github.com/bbc/psammead/pull/1930) Fix headline font-size in standard story promo |
| 2.7.0 | [PR#1835](https://github.com/bbc/psammead/pull/1835) Add desktop width top story and show indexAlsos |
| 2.6.2 | [PR#1923](https://github.com/bbc/psammead/pull/1923) Add support for RTL to Index Alsos |
| 2.6.1 | [PR#1845](https://github.com/bbc/psammead/pull/1845) Remove padding-bottom from Index Alsos Wrapper |
Expand Down
2 changes: 1 addition & 1 deletion packages/components/psammead-story-promo/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/components/psammead-story-promo/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@bbc/psammead-story-promo",
"version": "2.7.0",
"version": "2.7.1",
"main": "dist/index.js",
"module": "esm/index.js",
"sideEffects": false,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1435,8 +1435,8 @@ exports[`StoryPromo should render Live promo correctly 1`] = `

@media (min-width:37.5rem) {
.c4 {
font-size: 1.25rem;
line-height: 1.5rem;
font-size: 1.125rem;
line-height: 1.375rem;
}
}

Expand Down Expand Up @@ -1667,8 +1667,8 @@ exports[`StoryPromo should render correctly 1`] = `

@media (min-width:37.5rem) {
.c4 {
font-size: 1.25rem;
line-height: 1.5rem;
font-size: 1.125rem;
line-height: 1.375rem;
}
}

Expand Down Expand Up @@ -1935,8 +1935,8 @@ exports[`StoryPromo with Media Indicator should render correctly 1`] = `

@media (min-width:37.5rem) {
.c9 {
font-size: 1.25rem;
line-height: 1.5rem;
font-size: 1.125rem;
line-height: 1.375rem;
}
}

Expand Down
7 changes: 5 additions & 2 deletions packages/components/psammead-story-promo/src/index.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import {
import {
getPica,
getParagon,
getGreatPrimer,
getLongPrimer,
} from '@bbc/gel-foundations/typography';
import {
Expand Down Expand Up @@ -145,15 +146,17 @@ export const Headline = styled.h3`
if (!script) {
return '';
}

return topStory ? getParagon(script) : getPica(script);
}}
color: ${C_EBON};
${({ service }) => getSerifMedium(service)}
margin: 0; /* Reset */
padding-bottom: ${GEL_SPACING};
@media (min-width: ${GEL_GROUP_3_SCREEN_WIDTH_MIN}) {
${props => (props.script ? getParagon(props.script) : '')};
${props =>
This conversation was marked as resolved.
Show resolved Hide resolved
props.script && props.topStory
? getParagon(props.script)
: getGreatPrimer(props.script)}
}
`;

Expand Down