Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Fix headline font-size in standard story-promo #1930

Merged
16 commits merged into from
Aug 30, 2019
Merged

Fix headline font-size in standard story-promo #1930

16 commits merged into from
Aug 30, 2019

Conversation

ghost
Copy link

@ghost ghost commented Aug 28, 2019 •
edited by ghost
Loading

Resolves #NUMBER

Overall change: Apply getGreatPrimer on standard story promo above 600px

Code changes:

  • Update snapshots
  • Use getGreatPrimer on standard story promo above 600px.
  • I have assigned myself to this PR and the corresponding issues
  • Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@ghost ghost added the ws-home Tasks for the WS Home Team label Aug 28, 2019
@ghost ghost self-assigned this Aug 28, 2019
@ghost ghost marked this pull request as ready for review August 28, 2019 13:00
jroebu14
jroebu14 approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@jroebu14 jroebu14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghost ghost mentioned this pull request Aug 28, 2019
Closed
@ghost ghost added the high priority label Aug 28, 2019
DenisHdz
DenisHdz approved these changes Aug 28, 2019
View reviewed changes
Copy link
Contributor

@DenisHdz DenisHdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

sadickisaac and others added 3 commits August 28, 2019 18:53
sadickisaac and others added 2 commits August 28, 2019 20:43
@andrew-nowak
Update packages/components/psammead-story-promo/src/index.jsx
a18e22b 
Co-Authored-By: Andrew Nowak <10963046+aacn500@users.noreply.github.com>
@sadick254
Update snaps
b1290a6
@ghost ghost added the blocking label Aug 29, 2019
andrew-nowak
andrew-nowak approved these changes Aug 29, 2019
View reviewed changes
Copy link
Contributor

@andrew-nowak andrew-nowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep lgtm

@jamesbrumpton jamesbrumpton self-assigned this Aug 29, 2019
@staylos92 staylos92 mentioned this pull request Aug 29, 2019
Merged
@jamesbrumpton
Copy link
Contributor

lgtm

@ghost ghost merged commit a391cec into latest Aug 30, 2019
@ghost ghost deleted the fix-font-size branch August 30, 2019 09:39
This was referenced Oct 3, 2019
Closed
Closed
@pharingee pharingee mentioned this pull request Oct 15, 2019
Open
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamesbhobbs jamesbhobbs Awaiting requested review from jamesbhobbs

@dr3 dr3 Awaiting requested review from dr3

@j-pendlebury j-pendlebury Awaiting requested review from j-pendlebury

@sareh sareh Awaiting requested review from sareh

Assignees

@jamesbrumpton jamesbrumpton

Labels
high priority ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jamesbrumpton @jroebu14 @andrew-nowak @Bopchy @DenisHdz @sadick254