Remove react-test-renderer

[ghost]

Contributes to #774

Overall change: Remove react-test-renderer and shallow rendering for psammead-test-helpers

Code changes:

• Remove shallowRender and shouldShallowMatchSnapshot.
• Update isNull and shouldMatchSnapshot
• Use render from @testing-library/react

---

• I have assigned myself to this PR and the corresponding issues
• Automated (jest and/or cypress) tests added (for new features) or updated (for existing features)
• This PR requires manual testing

[thekp]

Hi @sadickisaac

I see you are removing the shallowRendering functionality. We currently have an on-going issue to make use of the psammead-test-helper in Simorgh, however the shallow rendering is heavily used in Simorgh for the page body tests (i.e simorgh/src/app/containers/ArticleMain: https://github.com/bbc/simorgh/blob/latest/src/app/containers/ArticleMain/index.test.jsx#L35-L54)

Do you know if @testing-library/react package has an equivalent "shallow rendering functionality" we can use ?

[thekp]

source of the CI issue btw: https://github.com/bbc/psammead/blob/latest/packages/components/psammead-media-player/src/Placeholder/index.test.jsx#L3

[ghost]

Do you know if @testing-library/react package has an equivalent "shallow rendering functionality" we can use ?

@testing-library/react does not support shallow rendering. We are trying to move from using shallow rendering. What will happen is, the test depending on shallowRendering will be refactored.

[thekp]

@testing-library/react does not support shallow rendering. We are trying to move from using shallow rendering. What will happen is, the test depending on shallowRendering will be refactored.

possibly major refactors to our Simorgh tests 👀(but I suppose it is inevitable since we want to move away from shallowRendering) I'm going to put my running issue on blocked until you get this one done: bbc/simorgh#3264 👍

[thekp]

This is ok for psammead, as we don't use shallowRender anywhere here.

This issue is for using test-helper in Simorgh: bbc/simorgh#3264