Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test helpers from simorgh #3264

Closed
dr3 opened this issue Aug 19, 2019 · 3 comments · Fixed by #3708, #3711, #3776, #3814 or #3842
Closed

Remove test helpers from simorgh #3264

dr3 opened this issue Aug 19, 2019 · 3 comments · Fixed by #3708, #3711, #3776, #3814 or #3842
Assignees
@FK78
Milestone
Simorgh 2.0

Comments

@dr3
Copy link

dr3 commented Aug 19, 2019 •
edited
Loading

Is your feature request related to a problem? Please describe.
We moved our test helpers to psammead monttttths ago, but we still use them in simorgh via simorgh/src/testHelpers/index.js

Describe the solution you'd like
Delete simorgh/src/testHelpers/index.js, first ensuring that all the commands we use are available in @bbc/psammead-test-helpers. If we have commands in simorgh test helpers that arnt in psammead test helpers, move them first

Everywhere simorgh test helpers are used, use @bbc/psammead-test-helpers instead

  • [ ] This feature is expected to need manual testing.

Additional context
Add any other context or screenshots about the feature request here.
@dr3 dr3 added Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. simorgh-core-stream labels Aug 19, 2019
@jamesbhobbs jamesbhobbs added this to the Simorgh 2.0 milestone Aug 20, 2019
@FK78 FK78 self-assigned this Aug 22, 2019
@FK78 FK78 removed the Refinement Needed This is ready for refinement. It shouldn't be worked on until it has been refined by Dev & Test. label Aug 22, 2019
This was referenced Aug 22, 2019
Merged
Closed
@FK78
Copy link
Contributor

FK78 commented Aug 27, 2019

Blocked by #1917

@FK78 FK78 closed this as completed Aug 27, 2019
@FK78 FK78 reopened this Aug 27, 2019
@FK78 FK78 added the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Aug 27, 2019
@thekp thekp mentioned this issue Aug 27, 2019
Merged
3 tasks
@ghost
Copy link

ghost commented Aug 29, 2019

This is now unblocked BBC-archive/psammead#1917 has been merged

@ghost ghost removed the blocked This issue should not be worked on until another internal issue is completed - see desc for details label Aug 29, 2019
@ghost
Copy link

ghost commented Aug 29, 2019 •
edited by ghost
Loading

But might be blocked on BBC-archive/psammead#774 since we don't have shallow rendering and shallow match snapshots. Some test needs to be refactored

@FK78 FK78 mentioned this issue Sep 11, 2019
Merged
3 tasks
@FK78 FK78 mentioned this issue Sep 11, 2019
Merged
3 tasks
@FK78 FK78 reopened this Sep 16, 2019
@FK78 FK78 mentioned this issue Sep 16, 2019
Merged
3 tasks
This was referenced Sep 17, 2019
Merged
Merged
Merged
@FK78 FK78 reopened this Sep 19, 2019
@FK78 FK78 mentioned this issue Sep 19, 2019
Closed
1 task
@FK78 FK78 reopened this Sep 19, 2019
@FK78 FK78 mentioned this issue Sep 20, 2019
Merged
3 tasks
@FK78 FK78 reopened this Sep 23, 2019
@FK78 FK78 mentioned this issue Sep 24, 2019
Merged
3 tasks
@FK78 FK78 reopened this Sep 25, 2019
@FK78 FK78 closed this as completed in #3945 Oct 1, 2019
@FK78 FK78 mentioned this issue Oct 1, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FK78 FK78

Labels
None yet
Projects
None yet
Milestone
Simorgh 2.0
3 participants
@dr3 @jamesbhobbs @FK78