Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

ScriptLink hit area does not meet design criteria #2953

Closed
1 task
Bopchy opened this issue Jan 17, 2020 · 1 comment
Closed
1 task

ScriptLink hit area does not meet design criteria #2953

Bopchy opened this issue Jan 17, 2020 · 1 comment
Labels
bug Something isn't working low-priority ws-articles Tasks for the WS Articles Team ws-media The World Service media stream

Comments

@Bopchy
Copy link
Contributor

Bopchy commented Jan 17, 2020

Describe the bug
ScriptLink touch hit area does not fulfil design criteria. The size of the hit area should be 44px by 44px for group A, B and C.

Expected behaviour
The ScriptLink should have a touch area of 44px for group A, B and C as pictured in the designs - https://app.zeplin.io/project/5c8a5e021d454124ef90669f/screen/5db96f04b9175d22aa0036c5

Screenshot 2019-12-02 11 04 58

Possible solution
The way to achieve this touch area is with an implementation similar to this example here (though don’t necessarily copy this CSS letter for letter, I’ve just knocked it up quickly) http://2bitstudio.co.uk/code-tests/world-service/script-link.html

Testing notes

  • This bug fix is expected to need manual testing.

Additional context
Add any other context about the problem here.

@Bopchy Bopchy added bug Something isn't working ws-home Tasks for the WS Home Team low-priority labels Jan 17, 2020
@Bopchy
Copy link
Contributor Author

Bopchy commented Jan 17, 2020

A previous attempt at resolving this issue can be found on here but the use pseudo styling caused a problem with Read&Write due to there being an invisible layer over the element which means that Read&Write wasn't able to access it.

@amywalkerdev amywalkerdev added ws-media The World Service media stream ws-articles Tasks for the WS Articles Team and removed ws-home Tasks for the WS Home Team labels Jun 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working low-priority ws-articles Tasks for the WS Articles Team ws-media The World Service media stream
Projects
None yet
Development

No branches or pull requests

3 participants