Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Add pseudo element to ScriptLink. #2750

Merged
merged 9 commits into from
Dec 3, 2019
Merged

Add pseudo element to ScriptLink. #2750

merged 9 commits into from
Dec 3, 2019

Conversation

Bopchy
Copy link
Contributor

@Bopchy Bopchy commented Dec 3, 2019 •
edited
Loading

Resolves #2751

Overall change: Add before pseudo element to ScriptLink, to increase ScriptLink touch area.

Code changes:

  • Add before and after pseudo element to ScriptLink.
  • Update snapshots.
  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@Bopchy Bopchy self-assigned this Dec 3, 2019
@Bopchy Bopchy added the ws-home Tasks for the WS Home Team label Dec 3, 2019
@Bopchy Bopchy marked this pull request as ready for review December 3, 2019 10:19
j-pendlebury
j-pendlebury approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@j-pendlebury j-pendlebury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Bopchy Bopchy mentioned this pull request Dec 3, 2019
Closed
1 task
@Bopchy Bopchy merged commit ebb6d57 into latest Dec 3, 2019
@Bopchy Bopchy deleted the fix-script-link-dimensions branch December 3, 2019 14:22
This was referenced Dec 30, 2019
Closed
Merged
Closed
@Bopchy Bopchy mentioned this pull request Jan 17, 2020
Closed
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@oluoluoxenfree oluoluoxenfree oluoluoxenfree approved these changes

@j-pendlebury j-pendlebury j-pendlebury approved these changes

@jamesbhobbs jamesbhobbs Awaiting requested review from jamesbhobbs

@craigkj craigkj Awaiting requested review from craigkj

@DenisHdz DenisHdz Awaiting requested review from DenisHdz

@jroebu14 jroebu14 Awaiting requested review from jroebu14

@sareh sareh Awaiting requested review from sareh

Assignees

@Bopchy Bopchy

Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ScriptLink touch area does not fulfil accessibility acceptance criteria
3 participants
@Bopchy @oluoluoxenfree @j-pendlebury