Skip to content
This repository has been archived by the owner on Aug 13, 2023. It is now read-only.

Fix script link read&write on IE #2833

Merged
merged 9 commits into from
Dec 23, 2019
Merged

Fix script link read&write on IE #2833

merged 9 commits into from
Dec 23, 2019

Conversation

ghost
Copy link

@ghost ghost commented Dec 17, 2019

Resolves #2776

Overall change: Fix script link read&write on IE.

Code changes:

  • Wrap scriptLink in a div - This fixes Chrome reading all of the content of the Brand component..
  • Refactor to remove the pseudoelement styling: This fixes the Read&Write issue.

  • I have assigned myself to this PR and the corresponding issues
  • Automated jest tests added (for new features) or updated (for existing features)
  • This PR requires manual testing

@ghost ghost added the ws-home Tasks for the WS Home Team label Dec 17, 2019
@ghost ghost self-assigned this Dec 17, 2019
@ghost ghost marked this pull request as ready for review December 19, 2019 07:11
@ghost ghost force-pushed the fix-script-link branch from 3385561 to b1e7110 Compare December 19, 2019 08:50
@ghost ghost requested review from EinsteinNjoroge, Bopchy and OlgaLyubin December 19, 2019 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ws-home Tasks for the WS Home Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Read&Write is not reading the script link on IE11 on windows (and incorrectly on Chrome)
5 participants