Merge pull request #2464 from bbc/changescanner-explanation

Add explanation to changeScanner error output

CHANGELOG.md

@@ -3,6 +3,7 @@
 <!-- prettier-ignore -->
 | Version | Description |
 |---------|-------------|
+| 1.8.30 | [PR#2464](https://github.com/bbc/psammead/pull/2464) Add more context to changeScanner error output |
 | 1.8.29 | [PR#2317](https://github.com/bbc/psammead/pull/2317) Bump @bbc/psammead-media-player |
 | 1.8.28 | [PR#2452](https://github.com/bbc/psammead/pull/2452) Bump dependencies (#2441 - #2445) |
 | 1.8.27 | [PR#2400](https://github.com/bbc/psammead/pull/2400) bump dependencies (#2385 - #2396) |

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@bbc/psammead",
-  "version": "1.8.29",
+  "version": "1.8.30",
   "description": "Core Components Library Developed & Maintained By The Articles and Reach & Languages Team",
   "main": "index.js",
   "private": true,

scripts/changeScanner/index.js

@@ -18,6 +18,9 @@ Object.keys(changes).forEach(packageName => {
 
 /* eslint-disable no-console */
 if (errors.length > 0) {
+  console.error(`Please update the version number and CHANGELOG for every package that is being
+changed in this branch. The following problems were found:
+`);
   errors.forEach(error => console.error(chalk.red(error)));
   console.error(''); // empty line for spacing
   process.exit(1);

scripts/changeScanner/index.test.js

@@ -69,9 +69,13 @@ describe(`changeScanner - index`, () => {
       '', // empty line for spacing
     ];
 
-    expect(consoleLogOutput).not.toHaveBeenCalled();
+    expect(consoleErrorOutput).toHaveBeenCalledTimes(
+      expectedMessages.length + 1,
+    );
 
-    expect(consoleErrorOutput).toHaveBeenCalledTimes(expectedMessages.length);
+    expect(consoleErrorOutput).toHaveBeenCalledWith(
+      expect.stringContaining('Please update the version number'),
+    );
 
     expectedMessages.forEach(msg =>
       expect(consoleErrorOutput).toHaveBeenCalledWith(msg),