Merge pull request #2457 from bbc/sitewide-links-bug

Fix storybook bug for Sitewide Links
BBC-archive · Oct 23, 2019 · d1a7ef3 · d1a7ef3
2 parents e22c13c + fce55c8
commit d1a7ef3
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/packages/components/psammead-sitewide-links/CHANGELOG.md b/packages/components/psammead-sitewide-links/CHANGELOG.md
@@ -3,6 +3,7 @@
 <!-- prettier-ignore -->
 | Version | Description |
 |---------|-------------|
+| 3.1.17 | [PR#2457](https://github.com/bbc/psammead/pull/2457) Show relevant link text when selecting service in storybook |
 | 3.1.16 | [PR#2440](https://github.com/bbc/psammead/pull/2440) Talos - Bump Dependencies - @bbc/psammead-styles |
 | 3.1.15 | [PR#2404](https://github.com/bbc/psammead/pull/2404) replace inputProvider and dirDecorator with withServicesInput |
 | 3.1.14 | [PR#2351](https://github.com/bbc/psammead/pull/2351) Fix styling for IE11 |

diff --git a/packages/components/psammead-sitewide-links/package-lock.json b/packages/components/psammead-sitewide-links/package-lock.json
diff --git a/packages/components/psammead-sitewide-links/package.json b/packages/components/psammead-sitewide-links/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@bbc/psammead-sitewide-links",
-  "version": "3.1.16",
+  "version": "3.1.17",
   "description": "React styled component for a sitewide-links",
   "main": "dist/index.js",
   "module": "esm/index.js",

diff --git a/packages/components/psammead-sitewide-links/src/index.stories.jsx b/packages/components/psammead-sitewide-links/src/index.stories.jsx
@@ -10,10 +10,11 @@ const buildLink = text => ({
   href: 'https://www.bbc.co.uk/news',
 });
 
-const links = Array(7)
-  .fill()
-  .map((el, n) => `link ${n}`)
-  .map(buildLink);
+const links = (text, service) =>
+  Array(7)
+    .fill()
+    .map((el, n) => (service === 'news' ? `link ${n}` : `${text} ${n}`))
+    .map(buildLink);
 
 storiesOf('Components|SitewideLinks', module)
   .addDecorator(withKnobs)
@@ -22,7 +23,7 @@ storiesOf('Components|SitewideLinks', module)
     'default',
     ({ text, service }) => (
       <SitewideLinks
-        links={links}
+        links={links(text, service)}
         copyrightText={service === 'news' ? 'copyright text' : text}
         externalLink={buildLink(service === 'news' ? 'external link' : text)}
         service={service}