This repository has been archived by the owner on Aug 13, 2023. It is now read-only.
POC: Increase utilities test coverage #224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisBAshton
suggested changes
Dec 17, 2018
added 9 commits
December 17, 2018 16:52
- Using the testing helper function to test the test helpers; That's pretty damn meta - Add testing for the error and console.log in `testUtilityPackages`
…tilities-test-coverage
…s/psammead into increase-utilities-test-coverage
pjlee11
commented
Dec 17, 2018
|
|
||
| describe('Psammead test helpers', () => { | ||
| it('should test all the utility exports exist and are the correct type', () => { | ||
| testHelpers.testUtilityPackages( |
There was a problem hiding this comment.
Using one of the test helper functions to test the test helper utility #meta
|
This will fail Jenkins and will need |
pjlee11
commented
Dec 17, 2018
|
|
bcmn
previously approved these changes
Dec 18, 2018
bcmn
previously approved these changes
Jan 4, 2019
pjlee11
force-pushed
the
increase-utilities-test-coverage
branch
from
a0445b6 to
3e3366c
Compare
bcmn
approved these changes
Jan 4, 2019
ChrisBAshton
approved these changes
Jan 4, 2019
dr3
approved these changes
Jan 4, 2019
pjlee11
changed the title
|
Due to 3 out of the 4 packages being dependant on changes to the test helper package I'm going to split this PR in two. Therefore closing this PR |
pjlee11
pushed a commit
that referenced
this pull request
Jan 4, 2019
Cherry pick changes to `psammead-test-helpers` from the POC PR - #224
This was referenced Jan 4, 2019
|
PR 1: #258 |
|
PR 2: #259 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #156
Adds a test helper method that takes an actual import and validates it has all the exported values it is expected to have. This can then be used to simplifying testing the utility packages exports
Has error handling logic for both new files (EG:
font.js) and for exported files within those files when:I have assigned myself to this PR and the corresponding issues
Tests added for new features
Test engineer approval
To get this work merged in I'll have to split out the changes in
psammead-test-helpersand then bump the version and publish to npm before then using the new test helper version in the other packages.That said, this PR can be tested locally by checking out this branch, then copy and paste the following command, which locally links all the necessary packages that once split out will in the future depend on
psammead-test-helpers:Finally, see the test coverage for the whole repo increase from something in the 50's% to over 89% 🎉