Upgrade CI from ghc 9.0.2 to ghc 9.2.8 #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We held back to GHC 9.0 because of a bug in 9.2.1, but that has been fixed. GHC 9.2.8 is the current recommended version by GHCUP. The CI output will now contain many new warnings, since GHC 9.2 warns about more issues -- this is okay, but we should work on resolving them (see GitHub issue 469).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub CI environments have GHC installed, but the version is changed from time to time. This caused a problem when it upgraded to 9.2.1, which had a bug that BSC triggered. At that time, we changed the CI workflow to explicitly specify the version of GHC, which we fixed to the 9.0.1 (and later bumped that to 9.0.2). The bug has been fixed and time has gone by, so it's time to reconsider what version of GHC to use. The current recommend version by GHCUP is 9.2.8, so this PR upgrades to that.
The GitHub environments have 9.6.2, which is the latest version. But let's stick with the stable recommended version (9.2.8), for releases. However, we should also test BSC with the newer GHC versions, but that's not addressed here -- I'll open an issue for adding testing of multiple GHC versions to the CI.
With this PR, the CI output will now contain many new warnings, since GHC 9.2+ warns about more issues. This is okay, but we should work on resolving them (see issue #469).