Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI should test BSC with newer GHC versions #581

Closed
quark17 opened this issue Jul 29, 2023 · 2 comments · Fixed by #660
Closed

CI should test BSC with newer GHC versions #581

quark17 opened this issue Jul 29, 2023 · 2 comments · Fixed by #660

Comments

@quark17
Copy link
Collaborator

quark17 commented Jul 29, 2023

PR #580 will upgrade the CI to use GHC 9.2.8, which is a stable recommended version, and what we will use for pre-built releases. There are, however, newer versions of GHC, specifically 9.4.5 and 9.6.2. We should add jobs to the CI to test BSC with these newer versions as well, so that we can monitor compatibility (and not discover it later when we want to upgrade).

@quark17
Copy link
Collaborator Author

quark17 commented Dec 30, 2023

I have a prototype on the reorg-ci branch of my fork, which abstracts the build and test jobs into a call-able workflow, that the top-level CI can call with specific OS and GHC version inputs. GitHub's display of nested jobs is a little confusing (and different for matrix and non-matrix callers), which you can see in the Actions tab, for example this run.

@quark17
Copy link
Collaborator Author

quark17 commented Dec 30, 2023

FYI, callable (or reusable) workflows is documented here: https://docs.github.com/en/actions/using-workflows/reusing-workflows

And I notice that you can specify a subset of a matrix to run, by not specifying any matrix variables and using include to specify only the configurations to run (see example in the GitHub documentation on matrix). Currently, I've defined two separate top-level jobs (one for the OS matrix and one for the latest GHC), but we could just combine those into one job that explicitly lists all the combinations to run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant