Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new API version (2017-05-15-preview). No other changes made #2

Merged
merged 14 commits into from
Oct 30, 2017
Merged

Adding new API version (2017-05-15-preview). No other changes made #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1c8a73a
Adding new API version (2017-05-15-preview). No other changes made, j…
finiteattractor Oct 17, 2017
ef01647
Updating readme.md file to also include the artifacts required by new…
finiteattractor Oct 17, 2017
9585ec0
Adding -preview i missed in my last commit
finiteattractor Oct 17, 2017
3c76a58
added preview to tag line
finiteattractor Oct 18, 2017
173426d
- Removed copied files as we know how to proceed without copying.
finiteattractor Oct 19, 2017
46fd933
refactoring and adding examples
finiteattractor Oct 23, 2017
19c89c1
- Consolidating parameters
finiteattractor Oct 23, 2017
5b9e1a6
- Fixed missing closing curly braces
finiteattractor Oct 24, 2017
c239a67
removed type property as we are not returning it
finiteattractor Oct 24, 2017
503a5ef
- renamed models to make more sense in generated code
finiteattractor Oct 24, 2017
d1a982a
Fix for wrong resource model name
finiteattractor Oct 24, 2017
bd5fc27
Fixed lots of example validation errors, swagger specs issues, and im…
finiteattractor Oct 30, 2017
446330e
Fixed subids in examples
finiteattractor Oct 30, 2017
369a1aa
setting x-ms-azureresource to false for non put resources
finiteattractor Oct 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions specification/automation/resource-manager/Microsoft.Automation/2015-10-31/definitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2954,6 +2954,21 @@
},
"description": "The runbook property associated with the entity."
},
"scheduleFrequency": {
"type": "string",
"description": "Gets or sets the frequency of the schedule.",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In last review Azure team were against using gets and sets. Can you change the description

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated all! Thanks!

"enum": [
"OneTime",
"Day",
"Hour",
"Week",
"Month"
],
"x-ms-enum": {
"name": "ScheduleFrequency",
"modelAsString": true
}
},
"ScheduleCreateOrUpdateProperties": {
"properties": {
"description": {
Expand All @@ -2975,18 +2990,7 @@
},
"frequency": {
"type": "string",
"description": "Gets or sets the frequency of the schedule.",
"enum": [
"OneTime",
"Day",
"Hour",
"Week",
"Month"
],
"x-ms-enum": {
"name": "ScheduleFrequency",
"modelAsString": true
}
"$ref": "#/definitions/scheduleFrequency"
},
"timeZone": {
"type": "string",
Expand Down
Loading