-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding new API version (2017-05-15-preview). No other changes made #2
Conversation
…ust copied all files and updated the version string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you will need to another block for api 2017-05-15-preview like this file has for 2015
https://github.com/AzureAutomationTeam/azure-rest-api-specs/blob/current/specification/automation/resource-manager/readme.md
so, that you can pass an argument for 2017 and generates SDK for you. Could you also try generating SDK using autorest. Weijie did it last week, please check with him for commands for SDK generation and linter (static validation)
@finiteattractor we can close this PR as this is not needed |
- Small refactoring to schedule model definition so i can share it. - Added new software update configuration specs
- Updating examples path
- Renamed some definitions to match resource - Fixing invalid references - Fixed example file name - Added two resources to readme.md file
- consolidated common properties (lastmodified/created-time/by)
@@ -2954,6 +2954,21 @@ | |||
}, | |||
"description": "The runbook property associated with the entity." | |||
}, | |||
"scheduleFrequency": { | |||
"type": "string", | |||
"description": "Gets or sets the frequency of the schedule.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In last review Azure team were against using gets and sets. Can you change the description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated all! Thanks!
Hi Mo, |
I can approve right now or you can change and then I approve. |
* added extension properties to Get & GetNode * fix indentation * fix indentation * changed description text * Adding new API version (2017-05-15-preview). No other changes made (#2) Adding new API version (2017-05-15-preview). Only three new resources added and all others reference the previous version. - Added resources: - SoftwareUpdateConfiguration - SoftwareUpdateConfigurationRun - SoftwareUpdateConfigurationMachineRun - Validations: - Autorest azure validations passed - x-ms-examples validated with no errors * Updated tag in global configuration Updated tag in global configuration to use the latest api version as per azure PR review comment
* added extension properties to Get & GetNode * fix indentation * fix indentation * changed description text * Adding new API version (2017-05-15-preview). No other changes made (#2) Adding new API version (2017-05-15-preview). Only three new resources added and all others reference the previous version. - Added resources: - SoftwareUpdateConfiguration - SoftwareUpdateConfigurationRun - SoftwareUpdateConfigurationMachineRun - Validations: - Autorest azure validations passed - x-ms-examples validated with no errors * Updated tag in global configuration Updated tag in global configuration to use the latest api version as per azure PR review comment * - Fixed 2 typos in URLs (#4) - Moved parameters inside operations as it was not showing properly in documentation.
Adding new API version (2017-05-15-preview). No other changes made, just copied all files and updated the version string.