Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set the validateStatus locally than globally for axios #2959

Merged
merged 6 commits into from
Feb 7, 2021
Merged

Set the validateStatus locally than globally for axios #2959

merged 6 commits into from
Feb 7, 2021

Conversation

sameerag
Copy link
Member

This PR is requested through a customer issue reported to AzureSDK:

MSAL currently sets a global Axios setting which may impact other uses of Axios. We recently received a customer-reported issue for this on the Azure Identity repo: Azure/azure-sdk-for-js#13343

This prevents overwriting of the settings of axios for any app that imports msal-node

@github-actions github-actions bot added the msal-node Related to msal-node package label Jan 31, 2021
@sameerag sameerag linked an issue Jan 31, 2021 that may be closed by this pull request
msal-node sets the global axios setting rather than setting locally #2951
Closed
11 tasks
@sameerag sameerag self-assigned this Jan 31, 2021
@coveralls
Copy link

coveralls commented Jan 31, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.02%) to 82.679% when pulling f123486 on axios-validate-status into 5cc21a9 on dev.

@sameerag sameerag merged commit 2b2cd49 into dev Feb 7, 2021
@sameerag sameerag deleted the axios-validate-status branch February 7, 2021 01:44
@ramya-rao-a
Copy link

Hello!
Is there an expected release date for an update to the msal-node package with this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelkubai samuelkubai samuelkubai approved these changes

@tnorling tnorling tnorling approved these changes

@jasonnutter jasonnutter jasonnutter approved these changes

@hectormmg hectormmg Awaiting requested review from hectormmg hectormmg is a code owner

Assignees

@sameerag sameerag

Labels
msal-node Related to msal-node package
Projects
None yet
Milestone
@azure/msal-node@1.0.0-beta.6
Development

Successfully merging this pull request may close these issues.

msal-node sets the global axios setting rather than setting locally
6 participants
@sameerag @coveralls @ramya-rao-a @jasonnutter @tnorling @samuelkubai