Merge pull request #2959 from AzureAD/axios-validate-status

Set the validateStatus locally than globally for `axios`
AzureAD · Feb 7, 2021 · 2b2cd49 · 2b2cd49
2 parents 5cc21a9 + f123486
commit 2b2cd49
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/change/@azure-msal-node-2021-01-30-21-38-37-axios-validate-status.json b/change/@azure-msal-node-2021-01-30-21-38-37-axios-validate-status.json
@@ -0,0 +1,8 @@
+{
+  "type": "prerelease",
+  "comment": "Set the validateStatus locally than globally for `axios` (#2959)",
+  "packageName": "@azure/msal-node",
+  "email": "sameera.gajjarapu@microsoft.com",
+  "dependentChangeType": "patch",
+  "date": "2021-01-31T05:38:37.318Z"
+}
diff --git a/lib/msal-node/src/network/HttpClient.ts b/lib/msal-node/src/network/HttpClient.ts
@@ -15,9 +15,6 @@ import axios, { AxiosRequestConfig } from "axios";
  * This class implements the API for network requests.
  */
 export class HttpClient implements INetworkModule {
-    constructor() {
-        axios.defaults.validateStatus = () => true;
-    }
 
     /**
      * Http Get request
@@ -32,6 +29,7 @@ export class HttpClient implements INetworkModule {
             method: HttpMethod.GET,
             url: url,
             headers: options && options.headers,
+            validateStatus: () => true
         };
 
         const response = await axios(request);
@@ -56,6 +54,7 @@ export class HttpClient implements INetworkModule {
             url: url,
             data: (options && options.body) || "",
             headers: options && options.headers,
+            validateStatus: () => true
         };
 
         const response = await axios(request);