Using android.support.customtabs for android api 29+ #2510
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2418
The proper way to support custom tabs on android 29+ is to use the new custom tab intent as described here.
While trying out the new CustomTabsIntent, the custom tab shows up but our code does not capture the auth response. It will take a bit of work in MSAL to get this to happen so in the meantime we can use the android.support.customtabs implemented in this PR
Tested on andoridX and 11