Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using android.support.customtabs for android api 29+ #2510

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

trwalke
Copy link
Member

@trwalke trwalke commented Mar 26, 2021

Fix for #2418
The proper way to support custom tabs on android 29+ is to use the new custom tab intent as described here.

While trying out the new CustomTabsIntent, the custom tab shows up but our code does not capture the auth response. It will take a bit of work in MSAL to get this to happen so in the meantime we can use the android.support.customtabs implemented in this PR

Tested on andoridX and 11

@trwalke trwalke changed the title Using legacy support for custom tabs for android api 29+ Using android.support.customtabs for android api 29+ Mar 26, 2021
Copy link
Contributor

@pmaytak pmaytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to use the androidx custom tabs besides that androidx are newer libraries? Can we just keep classic support custom tabs if it works on all Android versions?

@trwalke
Copy link
Member Author

trwalke commented Mar 26, 2021

Not entirely sure yet. I will need to sync with the android team for more info. However, this is working with classic support for now

@trwalke trwalke closed this Mar 26, 2021
@trwalke trwalke reopened this Mar 26, 2021
Copy link
Collaborator

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@trwalke trwalke merged commit 98c9f7b into master Mar 26, 2021
@trwalke trwalke deleted the trwalke/AndoridCustomTabs branch March 26, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants