-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Cannot use Custom Tabs with Android 29+ #2418
Comments
Closing as duplicate of #2139 |
Not a duplicate. this is the second issue identified in #2139 |
@tipa it appears that there is a new way to implement the custom tabs in android 29. Ive been playing around with it to see if there is a way to adapt our code with it to make it work. I managed to get the custom tab to show up but the responses do not return to our code at the moment. I was also able to get the legacy support for custom tabs to work so I think it will be ok for us to use that for now. |
Not sure what you mean with legacy support buty ou can test the file attached if you need it. I am using it successfully to authenticate to many services, like Dropbox, Google Drive etc. You can start the auth flow with |
@tipa I was referring to using as opposed to which would require us to use the custom tab intent here this appears to be the way to implement customtabs in android 29+ Perhaps legacy is the wrong word. I am able to get the custom tabs working again with "android.support.customtabs.action.CustomTabsService" however so we can release a fix with that |
Yay, looks fixed with 4.29.0 - thanks! |
Thank you for patience @tipa ! |
Logs and Network traces
Without logs or traces, it is unlikely that the team can investigate your issue. Capturing logs and network traces is described at https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/wiki/logging
Which Version of MSAL are you using ?
MSAL 4.24.0 +
Platform
xamarin android
What authentication flow has the issue?
Repro
Ensure the app is targeting android 10 (API 29) in the project properties.
Ensure that the system browser is enabled in MSAL.NET (Should be on by default)
Try to acquire a token interactively
Expected behavior
MSAL should launch the custom tab browser for authentication
Actual behavior
The system browser is launched without custom tabs.
Possible Solution
Try modifying the browser tab packages that are used in the interactive auth.
microsoft-authentication-library-for-dotnet/src/client/Microsoft.Identity.Client/Platforms/Android/SystemWebview/AuthenticationActivity.cs
Lines 37 to 45 in d451b16
The text was updated successfully, but these errors were encountered: