Globals

[unindented]

Why does adal-angular expose globals? It stops me from importing the module normally through require or import.

Also, why not separate adal from adal-angular? Makes no sense to import adal-angular on a react project...

[brentschmaltz]

@rohitnarula7176 can we get this into 1.0.14 seems to be a hassle for users.

[jamesgraham]

Hi, is there any update on when this might happen?

[jmprieur]

adal is separated from adal-angular, and you can use plain adal.js. Please have a look at this sample: https://github.com/Azure-Samples/active-directory-dotnet-webapi-onbehalfof/tree/additionalClaimsSupport/TodoListSPA

We still need to update the README.md file to promote the plain JavaScript implementation, though.

[jamesgraham]

Thanks Jean-Marc! It would be great to install that via npm too. For now we have it hotlinked.

On Tue, 25 Jul 2017 at 18:43, Jean-Marc Prieur ***@***.***> wrote: adal is separated from adal-angular, and you can use plain adal.js. Please have a look at this sample: https://github.com/Azure-Samples/active-directory-dotnet-webapi-onbehalfof/tree/additionalClaimsSupport/TodoListSPA We still need to update the README.md file to promote the plain JavaScript implementation, though. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#443 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA5Cjm6mX2wCSv7Lcxho_kXBatyjO4gIks5sRg0HgaJpZM4K2rZd> .

-- Kind regards, James Graham

[jmprieur]

@jamesgraham : Unless I'm wrong, it is already? https://www.npmjs.com/package/adal-angular
(the angular package contains both the scripts for adal.angular and adal.js)

[jamesgraham]

Ah- I'm looking for a non angular npm package- surely a core library shouldn't be coupled to a framework

On Wed, 26 Jul 2017 at 11:49, Jean-Marc Prieur ***@***.***> wrote: @jamesgraham <https://github.com/jamesgraham> : Unless I'm wrong, it is already? https://www.npmjs.com/package/adal-angular (the angular package contains both the scripts for adal.angular and adal.js) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#443 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA5CjnKVQHFO2y5HqgokUdFMf4KfWWLtks5sRv21gaJpZM4K2rZd> .

-- Kind regards, James Graham

[pauldalyii]

I second @jamesgraham's comments. I'm working with react and don't want to unnecessarily pull in an angular dependency.

@jmprieur, would you consider reopening this? Could the adal-angular npm package take a dependency on a new adal only package?

[jmprieur]

• @navyasric

[RehanSaeed]

I would go further and split this repo so we can have a ReadMe dedicated to adak.js too. I've raised #659 to this effect.

[pauldalyii]

Is there a rough timeline for either this or #659?

[sameerag]

All current authentication work from microsoft is delivered through msal js library here. adal js is still supported only for security fixes. We would recommend to move to msal js for any advanced feature asks.

msal js angular work is in progress; please watch the space here and we appreciate any feedback on angular in that space.