Please Split this Repository into adal-angular and adal.js

[RehanSaeed]

The SPA world has moved on from Angular 1. There are now a myriad of frameworks out there. This project should be split into two repositories, adal-angular and adal.js.

For any developer coming from React, Vue.js, Aurelia, Ember, Polymer etc. taking one look at the ReadMe for this repo, they'd be forgiven for thinking that they'd arrived at the wrong place. All the documentation is specific to Angular. I really want to see a simple ReadMe for adal.js I can read in 5 mins and get going quickly.

As well as the repository, the NPM package should also be split. To import just adal.js in my code I have to write this magic incantation:

import "adal-angular/dist/adal.min";

Instead of:

import "adal";

Finally, this even causes issues with TypeScript (See #61). I'm trying to use @types/adal (The code in this repo should really be written in TypeScript but that is another matter) but the type decleration files get mixed up because adal and adal-angular both exist in there.

[ralexand56]

Yes, this is common sense

[unindented]

@rohitnarula7176 any progress on this?

[eelkram]

This would be a huge help!

[grumar]

+1

[hkusulja]

I am also interested in having separate, MS ADAL Angular5 supported library

[talorlik]

I've been battling with this like crazy.

There's also very confusing bits of information and explanation how to go about this process.

I'm most interested in an Angular 5 implementation.

[aciccarello]

This would help with getting TypeScript definitions (see DefinitelyTyped/DefinitelyTyped#12586)

[nithinmohantk]

I agree this needs a split into two repos.

[Shenrak]

I can't even launch my app because 'angular' isn't defined in my react project...

Needs a split.

[aciccarello]

@Shenrak, you should be able to use the pure JS file that doesn't require angular. Splitting the repo is more about convenience than technical limitations.

[TedPattison]

If you are not using angular.js, it is really difficult to to decide the best way to consume adal.js from TypeScript and webpack. It seems like your team spent the energy to create d.ts support for angular.js and now you have run out of energy to provide d.ts files and TypeScript support for adal.js in anything else including just using adal.js by itself. It doesn't seem like it would be a bigger effort to create an official adal.d.ts file and it would make adoption of this library sooooooo much easier.

Your response that "you should be able to use the pure JS file that doesn't require angular. Splitting the repo is more about convenience than technical limitations." Yes, I agree it would be very convenient not to spend 2 days going testing out and experimenting with the with d.ts files and TypeScript support in NPM packages such as from adal-angular, modular-adal-angular, adal-ts and the deprecated adal.d.ts file your team created a ways back..

The confusion and lack of Microsoft guidance about using adal.js with typescript and webpack when not using angular.js is more than a lack of convenience. It is a serious roadblock to adoption.

[ralexand56]

I believe they are putting their development work into the msal.js library. It certainly would be nice if there was some guidance though.

[TallOrderDev]

+1 No comment from anyone from Microsoft yet? 8 months and we should at least have an idea of whats happening by now. Please please, can we at least get some feedback.

[baywet]

Pinged a Microsoft PM by email today, hopefully that should help get an answer at least.

[navyasric]

Thank you all for the feedback. We are investing future efforts in the MSAL.js library and will be creating separate packages for supporting frameworks.

[mlynam]

Hey @navyasric has this issue been abandoned?

[baywet]

@mlynam this has been addressed in msal as you can see here https://github.com/AzureAD/microsoft-authentication-library-for-js/tree/dev/lib

[mlynam]

Thank you @baywet. I was confused by the ADAL Microsoft docs. They pointed me at the adal-angular library instead of msal.

[baywet]

do you still have the link? don't hesitate to open issues on the docs as well (all the way at the bottom, they also open github issues)

[mlynam]

Yeah I got it from here: https://docs.microsoft.com/en-us/azure/active-directory/develop/active-directory-authentication-libraries. I admit that I glanced over the note asking if I was looking for Azure 2.0 (MSAL)...

[baywet]

thanks. yeah this page is probably going to stay like this as it already has a note pointing to msal

[sameerag]

All current authentication work from microsoft is delivered through msal js library here. adal js is still supported only for security fixes.

For this specific question, we have structured msal js better and there is a split between msal-core and msal-angular, please checkout our repo.