Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHEL8 spec update to require moby-engine or docker-ce #7026

Merged
merged 5 commits into from
May 25, 2023

Conversation

bilalsellak
Copy link
Contributor

Adding a requires clause to spec for rhel8 "Requires: (moby-engine or docker-ce)", as well as moving check for docker group to %post.

Azure IoT Edge PR checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

  • [ x] I have read the contribution guidelines.
  • [ x] Title of the pull request is clear and informative.
  • [ x] Description of the pull request includes a concise summary of the enhancement or bug fix.

Testing Guidelines

  • [] Pull request includes test coverage for the included changes.
  • Description of the pull request includes
    • concise summary of tests added/modified
    • [x ] local testing done.

Draft PRs

  • Open the PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.

Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned here for the PR title and description

Earlier merge of RHEL8 install script changes broke the E2E tests. This is to fix it

## Azure IoT Edge PR checklist:
and-rewsmith
and-rewsmith previously approved these changes May 17, 2023
Co-authored-by: Damon Barry <damonbarry@users.noreply.github.com>
@bilalsellak bilalsellak merged commit 3a2e68e into Azure:release/1.4 May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants