RHEL8 spec update to require moby-engine or docker-ce

[bilalsellak]

Adding a requires clause to spec for rhel8 "Requires: (moby-engine or docker-ce)", as well as moving check for docker group to %post.

Azure IoT Edge PR checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines and Best Practices

• [ X] I have read the contribution guidelines.
• [ X] Title of the pull request is clear and informative.
• [X ] Description of the pull request includes a concise summary of the enhancement or bug fix.

Testing Guidelines

• Pull request includes test coverage for the included changes.
• Description of the pull request includes
  • concise summary of tests added/modified
  • local testing done.

Draft PRs

• Open the PR in Draft mode if it is:
  • Work in progress or not intended to be merged.
  • Encountering multiple pipeline failures and working on fixes.

Note: We use the kodiakhq bot to merge PRs once the necessary checks and approvals are in place. When it merges a PR, kodiakhq converts the PR title to the commit title, PR description to the commit description, and squashes all the commits in the PR to a single commit. The net effect is that entire PR becomes a single commit. Please follow the best practices mentioned here for the PR title and description

[arsing]

What about edgelet/contrib/centos/aziot-edge.spec ? Did you test that it does not support or ?

[bilalsellak]

What about edgelet/contrib/centos/aziot-edge.spec ? Did you test that it does not support or ?

Just tested this. Does not support or

[arsing]

Cool, so just test these scenarios on EL8 to be sure:

1. With neither Docker repo nor MS repo added, yum install aziot-edge should fail because it can't satisfy the requirement.

2. With just Docker repo added but not MS repo, yum install aziot-edge should automatically pull in docker-ce.

3. With just MS repo added but not Docker repo, yum install aziot-edge should automatically pull in moby-engine.

4. With both Docker and MS repos added, what does it do?

[bilalsellak]

Cool, so just test these scenarios on EL8 to be sure:

1. With neither Docker repo nor MS repo added, yum install aziot-edge should fail because it can't satisfy the requirement.
2. With just Docker repo added but not MS repo, yum install aziot-edge should automatically pull in docker-ce.
3. With just MS repo added but not Docker repo, yum install aziot-edge should automatically pull in moby-engine.
4. With both Docker and MS repos added, what does it do?

Defaults to docker repo

[arsing]

Hmm, it would be nice if it preferred moby-engine, but I guess it's fine.