Add Custom Repo Support For Jammy #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
adamperlin
force-pushed
the
adamperlin/extra-repo-support-jammy
branch
from
3e6d15c to
c4d58d0
Compare
cpuguy83
requested changes
Oct 23, 2024
| outPath := filepath.Join("/tmp/out", name) | ||
| keySt = worker.Run( | ||
| // dearmor key if necessary | ||
| ShArgs(fmt.Sprintf("cat '%s' | gpg --dearmor --output '%s'", inPath, outPath)), |
There was a problem hiding this comment.
Suggested change
| ShArgs(fmt.Sprintf("cat '%s' | gpg --dearmor --output '%s'", inPath, outPath)), | |
| ShArgs(fmt.Sprintf("gpg --dearmor --output '%s' < '%s'", inPath, outPath)), |
This removes an extra call to cat
cpuguy83
requested changes
Oct 23, 2024
| return dalec.WithRunOptions(withRepos, withData, keyMounts), nil | ||
| } | ||
|
|
||
| func installPackages(ls []string, rOpts ...llb.RunOption) llb.RunOption { |
There was a problem hiding this comment.
Since this is returning a RunOption does it need to accept run options?
I think we should be able to append the repo/key stuff separately.
cpuguy83
approved these changes
Oct 23, 2024
|
Had to open a fix for the custom repo tests: #415 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a follow up PR to #366. With this PR Dalec now accepts specifying dependencies from outside package repos on Jammy targets.
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #211
Special notes for your reviewer: