-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom repo support for AzLinux #366
Merged
cpuguy83
merged 11 commits into
Azure:main
from
adamperlin:adamperlin/extra-repo-support
Oct 22, 2024
Merged
Custom repo support for AzLinux #366
cpuguy83
merged 11 commits into
Azure:main
from
adamperlin:adamperlin/extra-repo-support
Oct 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamperlin
commented
Sep 7, 2024
adamperlin
commented
Sep 7, 2024
Signed-off-by: adamperlin <adamp@nanosoft.com>
…ngs are broken right now, but the general idea is to create mounts for 1. The repo config files 2. Any pgp keys that need to be imported 3. Any repo data that needs to be accessible and then to apply those mounts as RunOptions when we tdnf install the build dependencies package. This doesn't seem to be working properly and I'm not confident RunOptions for the mounts are threaded through exactly right.
adamperlin
force-pushed
the
adamperlin/extra-repo-support
branch
from
October 11, 2024 22:40
6e2591d
to
9b8fb84
Compare
Refactoring to pass all repo-related options as installOpts with single function to construct
adamperlin
changed the title
[Broken] WIP draft for custom repo support
Custom repo support for AzLinux
Oct 16, 2024
cpuguy83
requested changes
Oct 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor thing but otherwise this LGTM
Great work!
… generic with RepoPlatformConfig type
cpuguy83
approved these changes
Oct 22, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds custom repo support for Azure Linux. Jammy support soon to come. This means that packages from custom imported repos outside of the built-ins for a distro may be specified as dependencies in Dalec for the Build, Install, and Test phases.
The following spec fragment gives a good example of the feature:
Note that the
keys
portion of the spec would not be necessary if the repo config references a key directly via http in thegpgkey
field.Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Closes #211
Special notes for your reviewer: