Revoke public interface change. #876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencefan
force-pushed
the
revoke
branch
3 times, most recently
from
443f951 to
0eaa4af
Compare
terencefan
commented
Apr 17, 2020
| @@ -143,7 +143,7 @@ public Task<string> GenerateClientAccessToken(string hubName, string userId = nu | |||
| { | |||
| claimsWithUserId.AddRange(claims); | |||
| } | |||
| return _endpointProvider.GenerateClientAccessTokenAsync(hubName, claimsWithUserId, lifeTime); | |||
| return _endpointProvider.GenerateClientAccessTokenAsync(hubName, claimsWithUserId, lifeTime).Result; | |||
There was a problem hiding this comment.
This is a quick fix of #861 . We don't actually have this method awaitable at this moment.
But it would probably cause a deadlock if you embed a Task.Wait inside an async method.
(Task.Result does things that similar to Task.Wait)
https://stackoverflow.com/questions/13140523/await-vs-task-wait-deadlock
So try avoiding doing something like this:
async Task Get(){ var token = manager.GenerateClientAccessToken; }We will provide an async version of this API later on another PR.
vicancy
approved these changes
Apr 17, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.