Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AAD] make GetAccessToken async #861

Merged
merged 1 commit into from
Mar 31, 2020
Merged

[AAD] make GetAccessToken async #861

merged 1 commit into from
Mar 31, 2020

Conversation

terencefan
Copy link
Member

Since a server-generated AccessKey may need to be authorized in the future. Change the GetAccessToken methods to async (for both server and client connections)

@terencefan terencefan force-pushed the async-get-access-token branch 3 times, most recently from e351969 to 8883fab Compare March 30, 2020 05:11
@terencefan terencefan force-pushed the async-get-access-token branch from 8883fab to 96462be Compare March 30, 2020 07:09
@terencefan terencefan merged commit 0ac6821 into Azure:dev Mar 31, 2020
@terencefan terencefan deleted the async-get-access-token branch March 31, 2020 06:14
@sellotape
Copy link

This was a breaking change; any reason the version wasn't bumped to 2.x.x? Perhaps we should generally not expect semantic versioning in this repo?

Also it seems like a GenerateClientAccessTokenAsync() could instead have been added; at the moment you now have an async method without the (by now well-established) convention of an "Async" suffix for the name.

@vicancy
Copy link
Member

vicancy commented Apr 17, 2020

@sellotape thanks for pointing it out, this is a bug we are actively working on. The breaking change is introduced in unexpectedly.

@terencefan terencefan mentioned this pull request Apr 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JialinXin JialinXin JialinXin left review comments

@vicancy vicancy vicancy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@terencefan @sellotape @vicancy @JialinXin