Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR monitor/resource-manager] Add dynamic metric alert api #4896

Merged
merged 3 commits into from
Apr 30, 2019

Conversation

AutorestCI
Copy link
Contributor

@AutorestCI
Copy link
Contributor Author

AutorestCI commented Apr 18, 2019

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-monitor

You can install the package azure-mgmt-monitor of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_5677#egg=azure-mgmt-monitor&subdirectory=azure-mgmt-monitor"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_5677#egg=azure-mgmt-monitor&subdirectory=azure-mgmt-monitor"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_5677
  • pip install -e ./azure-mgmt-monitor

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_5677
  • pip wheel --no-deps ./azure-mgmt-monitor

Direct download

Your files can be directly downloaded here:

@codecov-io
Copy link

codecov-io commented Apr 18, 2019

Codecov Report

Merging #4896 into restapi_auto_monitor/resource-manager will increase coverage by 0.66%.
The diff coverage is 45.45%.

Impacted file tree graph

@@                            Coverage Diff                            @@
##           restapi_auto_monitor/resource-manager    #4896      +/-   ##
=========================================================================
+ Coverage                                  48.84%    49.5%   +0.66%     
=========================================================================
  Files                                       6865     6341     -524     
  Lines                                     195670   177310   -18360     
=========================================================================
- Hits                                       95566    87777    -7789     
+ Misses                                    100104    89533   -10571
Impacted Files Coverage Δ
...e/mgmt/monitor/models/multi_metric_criteria_py3.py 42.85% <16.66%> (-23.81%) ⬇️
...mgmt/monitor/models/dynamic_metric_criteria_py3.py 45.45% <45.45%> (ø)
...r/azure/mgmt/monitor/models/metric_criteria_py3.py 55.55% <50%> (+19.84%) ⬆️
...mgmt-monitor/azure/mgmt/monitor/models/__init__.py 52.98% <50%> (-0.05%) ⬇️
...or/models/dynamic_threshold_failing_periods_py3.py 62.5% <62.5%> (ø)
...e-mgmt-netapp/azure/mgmt/netapp/models/__init__.py 60% <0%> (-12.92%) ⬇️
...azure/mgmt/eventhub/v2017_04_01/models/__init__.py 58.82% <0%> (-12.85%) ⬇️
...edia/azure/mgmt/media/models/job_input_clip_py3.py 60% <0%> (-11.43%) ⬇️
...ervicebus/azure/mgmt/servicebus/models/__init__.py 58.44% <0%> (-10.88%) ⬇️
...dia/azure/mgmt/media/models/job_input_asset_py3.py 62.5% <0%> (-10.23%) ⬇️
... and 613 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7d9ffb...d249751. Read the comment docs.

Update dynamic threshold criteria descriptions
Fix PR comments: Revert name change + Use fake subscriptionId
@AutorestCI AutorestCI merged commit 5684570 into restapi_auto_monitor/resource-manager Apr 30, 2019
@AutorestCI AutorestCI deleted the restapi_auto_5677 branch April 30, 2019 18:43
@AutorestCI
Copy link
Contributor Author

This PR has been merged into #4563

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants